From 9e5cd40847268e111a9b6307716b94ae4c341fc9 Mon Sep 17 00:00:00 2001
From: xX-TheDoctor-Xx <guilhermesuicida123654@gmail.com>
Date: Sat, 23 Jul 2016 13:15:59 +0100
Subject: [PATCH] Added DataAvailable method in TcpClient which will return the
 number of bytes available in the stream Config functions are now inline
 NetworkMessage and NetworkBuffer are being reworked

---
 TODO                                          |   4 +++-
 .../Release/VoidNetVS.tlog/CL.command.1.tlog  | Bin 5934 -> 5326 bytes
 .../Release/VoidNetVS.tlog/CL.read.1.tlog     | Bin 224412 -> 196612 bytes
 .../Release/VoidNetVS.tlog/CL.write.1.tlog    | Bin 7550 -> 7242 bytes
 .../Release/VoidNetVS.tlog/unsuccessfulbuild  |   0
 include/NetworkBuffer.hpp                     |   2 +-
 include/TcpClient.hpp                         |   5 +++++
 src/Config.cpp                                |   8 +++----
 src/NetworkMessage.cpp                        |   2 +-
 src/TcpClientWindows.cpp                      |  21 ++++++++++--------
 src/Utility.cpp                               |  15 +++++++++++++
 11 files changed, 41 insertions(+), 16 deletions(-)
 create mode 100644 VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/unsuccessfulbuild

diff --git a/TODO b/TODO
index d943f55..ac410b0 100644
--- a/TODO
+++ b/TODO
@@ -8,4 +8,6 @@ new StringConverter class
 
 implement close() in TcpClientWindows
 
-implement ConfigReader methods
\ No newline at end of file
+implement ConfigReader methods
+
+Fix NetworkBuffer and NetworkMessage code
\ No newline at end of file
diff --git a/VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/CL.command.1.tlog b/VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/CL.command.1.tlog
index dbe76bcfe20a00c99d7a767869d6efe746fd60dc..9da15b6b58e451928bd830adcece6cc8aefcfac5 100644
GIT binary patch
delta 34
qcmZ3dcTRHy6W?S3ak<S3qI^t~t(X)h=Lkt{uH*c`xH(6tj0pg?iV9Ky

delta 66
zcmX@7xlV5b6W`=LynMXA46Y2pK<LQe&fvPakn=Ai7GXt!wJekM1QaF<2*_<#;NxQg
E07wfD{{R30

diff --git a/VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/CL.read.1.tlog b/VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/CL.read.1.tlog
index 1cd5e0079ed2f95125529ad75c2d06258d49ef7b..895359d375d4e81ef9bd53083fea7eb1e44ed94e 100644
GIT binary patch
delta 50
zcmV-20L}lL*$sq%41lx&rlptc@B$u_?%o!WP7as)^8yUFwDSV!c$duZ0w9+J5CRal
I)DHsq;B|c%00000

delta 635
zcmZo^;F)uiw_yw8vZd3X*)Z}=<}eYM{N$d&^a*#FSSJ57_S#-&%gAR8<8n=Ruw}H{
z-c!K%%Vgp)waFs)6(;AI)J;Di#3(R**$*bGiDnAh|Hv_MJe+<<j!9wqvZai2_09}d
z3^5Gh44w>r3@!}*Kvpo2@6O-@WIHi90%=c%C?FjIr2T<vVu14g3_)PNA5a~F@5129
z;09C~3e*$Apa)dz160e)z{P;wj$npJhTwXjQdb6F24e;zpizE6o(oW$4^TUVCZHWf
zw>QwFAfOqpK>Z-62LoAz%&7;tALtGggWP}ygaEN8&=^7nVAJmobi60nO9XYRV6i?F
z?D8Ol0n<NzU@DDw0-6a5e?tZXpp-F?<qULVC{UE3Em$lG0mf<&Fo1$#x+fl#o<46W
Nqtx~<OBr8O001zwd|&_o

diff --git a/VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/CL.write.1.tlog b/VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/CL.write.1.tlog
index e22ff995f3c1ee7689ecd4276f237ae001c529a5..19a0415139f15e0cd8d6fb74a9e05f1675717b34 100644
GIT binary patch
delta 56
zcmexob;@GH7xBpnvT~CrNcc@o;8xo_LE;|c<OKp!lj}r+z!GtM3X{(<icNmS8#K8`
KTx#+<>0JPb`4#2>

delta 65
zcmX?Q@y}|*7xBpn+<cSu1Oz5?aMw-N<MP{lMPdTuWCa10$**{WV3M1kNTo4Oj^neM
QTqja6*@x3_@&ze501b;4w*UYD

diff --git a/VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/unsuccessfulbuild b/VoidNetVS/VoidNetVS/Release/VoidNetVS.tlog/unsuccessfulbuild
new file mode 100644
index 0000000..e69de29
diff --git a/include/NetworkBuffer.hpp b/include/NetworkBuffer.hpp
index b85ec15..32e1c13 100644
--- a/include/NetworkBuffer.hpp
+++ b/include/NetworkBuffer.hpp
@@ -12,7 +12,7 @@ struct NetworkBuffer
 	NetworkBuffer();
 	~NetworkBuffer();
 
-	uint32 body_size;
+	byte *header = nullptr;
 	byte *body = nullptr;
 };
 
diff --git a/include/TcpClient.hpp b/include/TcpClient.hpp
index 53af62d..88cf530 100644
--- a/include/TcpClient.hpp
+++ b/include/TcpClient.hpp
@@ -34,7 +34,12 @@ public:
 
 	bool Connect();
 
+	bool DataAvailable(uint16 &size);
+
+	//this method will receive the messages automaticaly and use the callback methods
 	void ReceiveMessages();
+	
+	//this is a more manual method with no callbacks
 	const NetworkMessage &ReceiveMessage();
 	void SendMessage(const NetworkMessage &message);
 
diff --git a/src/Config.cpp b/src/Config.cpp
index d502120..1182417 100644
--- a/src/Config.cpp
+++ b/src/Config.cpp
@@ -1,21 +1,21 @@
 #include "Config.hpp"
 
-void Config::SetUsingConsole(bool value)
+inline void Config::SetUsingConsole(bool value)
 {
 	using_console = value;
 }
 
-bool Config::GetUsingConsole()
+inline bool Config::GetUsingConsole()
 {
 	return using_console;
 }
 
-void Config::SetLogToFile(bool value)
+inline void Config::SetLogToFile(bool value)
 {
 	log_to_file = value;
 }
 
-bool Config::GetLogToFile()
+inline bool Config::GetLogToFile()
 {
 	return log_to_file;
 }
diff --git a/src/NetworkMessage.cpp b/src/NetworkMessage.cpp
index ad45585..b76ee86 100644
--- a/src/NetworkMessage.cpp
+++ b/src/NetworkMessage.cpp
@@ -26,7 +26,7 @@ NetworkMessage::~NetworkMessage()
 const NetworkBuffer &NetworkMessage::EncodeMessage(const NetworkMessage &message)
 {
 	NetworkBuffer buffer;
-	uint16 size = buffer.body_size + 1;
+	uint16 size = sizeof(buffer.body_size) + sizeof(buffer.body);
 	byte *encoded_message = new byte[size]();
 	buffer.body_size = size;
 
diff --git a/src/TcpClientWindows.cpp b/src/TcpClientWindows.cpp
index 3c9d7bd..2ff5755 100644
--- a/src/TcpClientWindows.cpp
+++ b/src/TcpClientWindows.cpp
@@ -128,16 +128,19 @@ bool TcpClient::Connect()
 	return true;
 }
 
+bool TcpClient::DataAvailable(uint16 &size)
+{
+	return ioctlsocket(tcp_socket, FIONREAD, (u_long*)size) != NO_ERROR && size > 0;
+}
+
 const NetworkBuffer &TcpClient::receive_data_array()
 {
 	NetworkBuffer buffer;
 
-	int32 header_received = recv(tcp_socket, reinterpret_cast<char*>(buffer.body_size), 4, 0);
-
-	if (header_received != 4 || WSAGetLastError() != 0) // this header is completely unrelated to the network message header - this header is the body size of the network message
-	{
-		// there was a problem receiving the body size of the message or theres no header to receive
-	}
+	uint16 body_size;
+	if (DataAvailable(body_size))
+		buffer.body_size = body_size;
+	else return NetworkBuffer();
 
 	buffer.body = new byte[buffer.body_size]();
 	int32 body_received = recv(tcp_socket, reinterpret_cast<char*>(buffer.body), buffer.body_size, 0);
@@ -157,11 +160,11 @@ void TcpClient::receive_data(TcpClient *client)
 		if (message.valid)
 		{
 			if (message.tag == CONNECT) // some user has connected
-				client->OnConnect(message.sender);
+				std::async(std::launch::async, client->OnConnect, message.sender);
 			else if (message.tag == DISCONNECT) // some user has disconnected
-				client->OnDisconnect(message.sender);
+				std::async(std::launch::async, client->OnDisconnect, message.sender);
 			else
-				client->OnMessage(message.sender, message.tag, message.subject, message.data); // we received data
+				std::async(std::launch::async, client->OnMessage, message.sender, message.tag, message.subject, message.data); // we received data
 		}
 	}
 }
diff --git a/src/Utility.cpp b/src/Utility.cpp
index e9a6156..3108a28 100644
--- a/src/Utility.cpp
+++ b/src/Utility.cpp
@@ -145,3 +145,18 @@ const std::string & Utility::StringConverter::ToString(byte * bytes, uint16 star
 {
 	// TODO: insert return statement here
 }
+
+const void Utility::ConfigReader::ReadConfig(const std::string & file_name)
+{
+	return void();
+}
+
+const std::map<std::string, std::string>& Utility::ConfigReader::ReadNodes()
+{
+	// TODO: insert return statement here
+}
+
+const std::string & Utility::ConfigReader::operator[](uint16 index)
+{
+	// TODO: insert return statement here
+}